I wanna to know how much acceptable could be the idea to create a tabbed component inside device-page to display different informations.
My idea is that this component will come with some default tabs (such as Info, LAN, etc) and the tab names as his contents could be filled as configuration parameters.
This will help people that directly works with genieacs ui to organize the CPE informations as needed.
I haven’t developed this yet, i just want to know if this feature is really needed and them, if this community approves, i could contribute with this project with this feature.
Sounds like a good idea. I think it warrants being included upstream if implemented in a general enough way to serve different use cases.
Keep in mind though that for the next major release of GenieACS we’re working on making the UI almost entirely customizable (no patching necessary) where you can create custom components as easily as creating virtual parameters. So it remains to be seen how useful such a component (or any of the other default components) is going to be.
almost a year later, I got some time to implement this function, in resume, if the user want to use no-tabbed device-page, just don’t fill the “device tabs page” option in config, but when it is filled, it ignores “device page” configuration, without delete it, and use the tabbed configuration instead.
The structure of the tabbed page looks simple, has only 3 parameters:
label (The displayed name of tab)
route (The routing name of the tab, that will be like #!/device/< ID >/< ROUTE >)
components (The components that should be visible on current tab)
If no tab route is specified, first tab configured will be displayed.
I know that has some CSS fixes to do but, please see if this concept looks good to you @zaidka , if so i will proceed with pull request to code review.
Hi @frtnrn , this feature at devices page could be easily integrated in overview context, but still as a draft on github as i’m waiting @zaidka avaliation (and bless) to release it, when the final PR’s ready, i will open a new one to this feature.
hello @cdavid14
Could you share the structure of your deviced page so we can see what its structure would be? I’m wanting to implement these tabs in my acs.
Hi Everyone, i hadn’t time to do a best approach to this feature, and the PR #389 was reproved, so the idea is there, if someone can do a better approach is welcome, or maybe i’ll do it when i have more time
